This repository was archived by the owner on Sep 17, 2021. It is now read-only.
Add color management to Radar chart #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a nice addition. Before we add it in, could you please sign the CLA? These instructions should've appeared when creating the PR: Thank you for contributing a pull request. Please ensure that you have signed the CLA.
Thanks! |
|
@MeisterTea Any update on this? |
|
Sorry for the late answer marzolfb, I just signed the CLA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have added a few lines regarding the color management in the radar chart.
It checks if the fill property is an array and deals with it by using one color for each render or the colors specified.
The previous behavior is still working.