fix: [#2112] Add missing destination property to Request#2136
Open
coffeeandwork wants to merge 1 commit into
Open
fix: [#2112] Add missing destination property to Request#2136coffeeandwork wants to merge 1 commit into
coffeeandwork wants to merge 1 commit into
Conversation
Request was missing the destination getter, so accessing request.destination returned undefined instead of the empty string. Per the spec, destination is always "" for requests created via the Request constructor or fetch() — the browser only sets it internally for resource loads (scripts, images, etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request.destinationwas returningundefinedbecause the property wasn't implemented. Per the fetch spec, the destination is always""for requests created via theRequestconstructor orfetch()— the browser only sets it to something meaningful internally for resource loads (scripts, images, stylesheets, etc.).Added a read-only getter that returns
"".Fixes #2112
Testing
Added a check for
destinationin the existing default properties test. All existing Request tests still pass.