Improve Model Endpoint and Batch Job's Logging UX #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradithya
reviewed
Jul 27, 2021
so we revert to roman's react-lazylog version and use yarn install --network-concurrency 1
pradithya
reviewed
Jul 29, 2021
pradithya
reviewed
Jul 29, 2021
pradithya
reviewed
Jul 29, 2021
pradithya
reviewed
Jul 29, 2021
pradithya
reviewed
Jul 29, 2021
pradithya
reviewed
Jul 29, 2021
pradithya
reviewed
Jul 29, 2021
pradithya
reviewed
Jul 29, 2021
pradithya
reviewed
Jul 29, 2021
pradithya
reviewed
Jul 29, 2021
pradithya
pushed a commit
that referenced
this pull request
Oct 3, 2022
* Update lazy-log package * Refactor stream logs API * Introducing ContainerLogsView component * Support logging for pyfunc image builder and batch job * Fix batch job's image builder log. Support prefixing log with pod & container name * Add batch job executor log * Dockerfile: Add git so we Yarn installation can succeed * Use node:14 as node-builder base image * Colorized the pod + container in log * Use actions/setup-node@v2 and node v14 * Update react-lazylog package to use gojekfarm to sovle yarn install issue https://github.com/yarnpkg/yarn/issues/7212\#issuecomment-493720324 * We still need react-lazylog's prepare script. so we revert to roman's react-lazylog version and use yarn install --network-concurrency 1 * Refactor stackdriver log * Fix API's unit test first * Add more test to cluster and log_service * Fix UI wording * Update swagger * Make sure color lib turned on * Add build-essential and etc isntallation on Mlflows' Dockerfile * Update API test * Use gojekfarm's react-lazylog fork * Update how to close channel; getContainerLogs async * Use request.Context() for termintation * Fix API test * Modularize pprof routes into a spearate function * Address aria's review * Use unbuffered channel for sending log line * Periodically update component list and address reviews * Simplify component refresh & log api context cancellation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR improves the Logging UX by aggregating logs from several pods and containers to one stream. It allows the user to stream the component's logs (model, transformer, batch job driver/executor, image builder) instead of one container log at a time.
In this PR we also fixes following issues:
Does this PR introduce a user-facing change?:
Screenshots
Model and transformer
Pyfunc and it's image builder
Batch job
No model
No batch job
Checklist
Regenerated Golang and Python client if the PR introduce API changes-- To be raised in separate PR.