fix(list-box-selection): fix aria-label for clear button
#2134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified in #2131
ListBoxSelectionis used byMultiSelectandComboBox.Currently, it uses the incorrect aria-label for the clear selection button. It's using the
translateId(e.g.,"clearAll") instead of the user-friendly copy.A follow-up would be to adjust the copy based on
selectionCount. For example, forMultiSelect, there may be multiple values selected. ForComboBox, it wouldn't make much sense to have "Clear all selected items" if there is only one selected item.