feat(combo-box): add hideLabel prop
#2153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
changed the title
hideLabel prop to ComboBox
metonym
approved these changes
Apr 18, 2025
metonym
changed the title
hideLabel prop to ComboBoxhideLabel prop
|
Released in v0.89.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many form components have a
hideLabelprop that makes the label text only show up for screenreaders. It's useful when the placeholder is descriptive enough, but it was missing from ComboBox even though ComboBox does have a placeholder. This PR adds the functionality.Worth noting: this component uses
titleTextinstead oflabelText, which is inconsistent with (most) other components and could makehideLabelconfusing. I went withhideLabelbecause it's more consistent with the other components and we're still literally referring to a label role in the DOM. I would hope we could changetitleTexttolabelTextin a future breaking-changes-are-ok update.