Move explorer out of toolchain git repo #5270
Conversation
danakj
added
proposal
danakj
force-pushed
the
proposal-explorer
branch
6 times, most recently
from
5e6e220 to
7280907
Compare
danakj
force-pushed
the
proposal-explorer
branch
from
7280907 to
058e733
Compare
github-actions
bot
added
proposal rfc
proposals/p5270.md
Outdated
| repository. | ||
| 4. Add a `README.md` to the `explorer` repository that explains explorer is | ||
| archived and not under active development. | ||
| 5. Delete `//explorer` in the main `carbon-lang` repository. |
There was a problem hiding this comment.
Is Compiler Explorer still building explorer (visible at https://carbon.compiler-explorer.com/z/b61T6n44h)? Maybe something to double-check if you're not sure -- even with the archive repo, might want to just ensure it's turned off.
There was a problem hiding this comment.
I am unsure if it's building it still. There's nothing visible in the compiler-explorer git repo that would suggest either way. But since the binary isn't part of the nightly release tarball, and we don't provide a binary of the explorer in some other way, I am guessing that it is still being built.
If this is approved I will kick off a PR with compiler-explorer to remove the carbon-explorer, and that can prompt them to also stop building it.
I've added this as a step.
There was a problem hiding this comment.
FWIW, I suspect Chandler's ideal result would be leaving it on Compiler Explorer, just not building new versions.
There was a problem hiding this comment.
No strong opinion TBH. Whatever is easiest.
There was a problem hiding this comment.
Ok I will file an issue with them to discuss it.
There was a problem hiding this comment.
Hi folks, we're fine with keeping the existing explorer versions. Plus it means old links won't break even though the upstream explorer is gone.
Co-authored-by: Jon Ross-Perkins <[email protected]>
Co-authored-by: Jon Ross-Perkins <[email protected]>
proposals/p5270.md
Outdated
| [on the main branch](https://docs.github.com/en/search-github/github-code-search/understanding-github-code-search-syntax#using-qualifiers) | ||
| of a repository, so the `trunk` branch for the `carbon-lang` repository. To | ||
| maintain searchability, the explorer codebase must either remain on `trunk` in | ||
| `carbon-lang` or in a sibling repository. |
There was a problem hiding this comment.
Might be worth noting here that github search does appear to work in archived repositories.
|
Filed compiler-explorer/compiler-explorer#7550 to discuss with the compiler-explorer team |
The carbon-explorer is frozen and has been moved out of the main carbon-lang repo. We can keep serving an old build, but there's no need to keep building it from the archived repo. See #7550 and carbon-language/carbon-lang#5270
The carbon-explorer is frozen and has been moved out of the main carbon-lang repo. We can keep serving an old build, but there's no need to keep building it from the archived repo. See #7550 and carbon-language/carbon-lang#5270
The explorer is an archived codebase, without a plan to restart development on it. The costs incurred by keeping it in the main git repo can be alleviated by moving it to a new sibling repo, without diminishing the usefulness of the explorer codebase for demonstrating implementation of the carbon language design.