Skip to content

autoformatter for nix files#5084

Closed
disassembler wants to merge 1 commit into
cardano-foundation:masterfrom
DripDropz:sl/treefmt-nix
Closed

autoformatter for nix files#5084
disassembler wants to merge 1 commit into
cardano-foundation:masterfrom
DripDropz:sl/treefmt-nix

Conversation

@disassembler

@disassembler disassembler commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Reading and editing the nix code in this repository is very painful because it doesn't conform to any sort of standard structure. This uses the default treefmt-nix structure.

I've manually run treefmt once to reformat all nix files.

CI Check

To verify formatting is correct, run:

nix fmt -- --fail-on-change

This will fail if any nix files need reformatting.

@paolino paolino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is not running on this PR, I have to look at that

@paolino paolino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pls give me the exact commands you run, so they go in the CI ? Done

@paolino

paolino commented Feb 4, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #5090

@paolino paolino closed this Feb 4, 2026
paolino added a commit that referenced this pull request Feb 4, 2026
<!--
Detail in a few bullet points the work accomplished in this PR.

Before you submit, don't forget to:

* Make sure the GitHub PR fields are correct:
   ✓ Set a good Title for your PR.
   ✓ Assign yourself to the PR.
   ✓ Assign one or more reviewer(s).
   ✓ Link to a Jira issue, and/or other GitHub issues or PRs.
   ✓ In the PR description delete any empty sections
     and all text commented in <!--, so that this text does not appear
     in merge commit messages.

* Don't waste reviewers' time:
   ✓ If it's a draft, select the Create Draft PR option.
✓ Self-review your changes to make sure nothing unexpected slipped
through.

* Try to make your intent clear:
   ✓ Write a good Description that explains what this PR is meant to do.
   ✓ Jira will detect and link to this PR once created, but you can also
     link this PR in the description of the corresponding Jira ticket.
   ✓ Highlight what Testing you have done.
   ✓ Acknowledge any changes required to the Documentation.
-->

Expoes windowsPackages and musl64Packages for Daedalus.

built on #5084 to keep diff as small as possible

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number

<!-- Reference the Jira/GitHub issue that this PR relates to, and which
requirements it tackles.
  Note: Jira issues of the form ADP- will be auto-linked. -->
paolino added a commit that referenced this pull request Feb 4, 2026
Reading and editing the nix code in this repository is very painful
because it doesn't conform to any sort of standard structure. This uses
the default treefmt-nix structure.

I've manually run treefmt once to reformat all nix files.

## CI Check

To verify formatting is correct, run:

```bash
nix fmt -- --fail-on-change
```

This will fail if any nix files need reformatting.

---
Original PR: #5084 by @disassembler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants