fix: dereference symlinks when copying nix store paths in release-build#5134
Merged
Conversation
paolino
force-pushed
the
fix/5131-windows-cross-compile-chmod
branch
8 times, most recently
from
e4ff9d5 to
47df0c7
Compare
The DLLs in the haskell.nix output are symlinks to other store paths. `cp -R` preserves these symlinks, so `chmod +w` follows them back to the read-only nix store and fails with "Operation not permitted" on the CI builder (nix 2.24.11). Adding `-L` makes cp dereference all symlinks, producing real copies that can be chmod'd normally. Fixes #5131
paolino
force-pushed
the
fix/5131-windows-cross-compile-chmod
branch
from
47df0c7 to
dcd7f82
Compare
paolino
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cp -R→cp -RLinnix/release-build.nixcp -Rpreserves them, thenchmod +wfollows them to the read-only nix store and fails on the CI builder (nix 2.24.11)-Ldereferences all symlinks, producing real copies that can be chmod'dFixes #5131