fix: use readSignedObject for TLS client cert validation on Windows#5150
Merged
Conversation
paolino
changed the title
paolino
force-pushed
the
paolino/5110/windows-tls-fix
branch
from
506d217 to
c06c1c6
Compare
Diagnostic-only workflow to verify certificate stores on the Windows runner and confirm the root cause of #5110.
readCertificateStore fails on Windows when given a PEM file, causing the server to reject all client certificates. Use readSignedObject + makeCertificateStore instead, which works cross-platform.
Add ci.artifacts.win64.e2e bundle with e2e exe + wallet + node + cli. Rewrite windows-e2e.yml to use the new bundle, remove if: false.
Windows runners don't have 7z. Use `tar xzf` which works natively on both Linux (GNU tar) and Windows 10+ (BSD tar with gzip support).
paolino
force-pushed
the
paolino/5110/windows-tls-fix
branch
from
7d6dc58 to
f437bbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireClientAuthto usereadSignedObject+makeCertificateStoreinstead ofreadCertificateStorereadCertificateStorefromcrypton-x509-storefails on Windows when given a single PEM file, causing the server to reject all client certificates withCertificateUnknownFixes #5110
Test
All 6 TLS unit tests pass on Linux:
Needs Windows CI validation — will trigger once #5142 merges (re-enables
wallet-application-tlsin Windows CI).