fix: clean up E2E temp directories on cancellation#5195
Merged
Conversation
When E2E tests are cancelled (timeout or cancel-in-progress), the process gets SIGKILL'd and withSystemTempDirectory cleanup never runs, leaking ~17GB per run in /tmp/e2e-* and /tmp/test-cluster-* dirs. This filled the runner's tmpfs and broke all CI jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if: always()cleanup step to the E2E workflow to remove/tmp/e2e-*and/tmp/test-cluster*after each runProblem
When E2E tests get cancelled (timeout or
cancel-in-progress), the process is SIGKILL'd andwithSystemTempDirectorycleanup never runs. Each cancelled run leaks ~17GB in/tmp. Four stale dirs accumulated to ~57GB, filled the runner's 63GB tmpfs, and broke all CI jobs withdatabase or disk is fullerrors on the nix eval cache.Test plan
/tmponbuilder-new(93% → 1%)