feat: use standalone cardano-balance-tx library#5201
Merged
Conversation
paolino
force-pushed
the
paolino/issue-5200-use-standalone-balance-tx
branch
3 times, most recently
from
f281657 to
d692346
Compare
Replace internal lib/balance-tx/ with the standalone cardano-balance-transaction library. All imports updated from Internal.Cardano.Write.* to Cardano.Balance.Tx.*. Type conversions added in Shelley/Transaction.hs for wallet-primitive <-> standalone-primitive types.
The internal lib/balance-tx was deleted; remove its test references from ci.yml, macos-unit-tests.yml, windows.yml, and .gitignore.
paolino
force-pushed
the
paolino/issue-5200-use-standalone-balance-tx
branch
from
d692346 to
90614c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5200
lib/balance-tx/(14 modules, 192 files) with the standalonecardano-balance-transactionlibraryInternal.Cardano.Write.*/Cardano.Write.*toCardano.Balance.Tx.*Shelley/Transaction.hsfor wallet-primitive <-> standalone-primitive types (structurally identical newtypes from different packages)unit-cardano-balance-txtest reference and Windows test data setup fromflake.nixFollows the same pattern as #5193 (standalone
cardano-coin-selection).Test plan
cabal build all -O0compiles cleanlyfourmolu --mode checkpasses on all modified files