refactor: remove duplicate Block.Gen modules, consume from cardano-ledger-read#5206
Merged
Merged
Conversation
…dger-read Remove 5 modules (Gen, BlockParameters, Shelley, Babbage, Byron) that are now provided by cardano-ledger-read. Build.hs stays as wallet-specific DSL, importing mkBlockEra and BlockParameters from the library. Also bumps cardano-ledger-read s-r-p to include Gen modules and removes unused build-depends (cardano-crypto-praos, cardano-protocol-tpraos, deepseq, ouroboros-consensus, ouroboros-consensus-cardano, ouroboros-consensus-protocol, ouroboros-network-api). Closes #5205
2 tasks
paolino
added a commit
that referenced
this pull request
Feb 24, 2026
## Summary - Remove 35 inline `Cardano.Read.Ledger.*` source files and 5 `Block.Gen.*` modules - Consume from `cardano-ledger-read` library (node-10.6.2 branch, commit `0ce0e7a`) - Mirrors the same refactoring done on master (PRs #5204, #5206) - Build.hs retains local `txsL` lens definition ## Test plan - [x] `cardano-wallet-read` library compiles (34 modules) - [x] All 24 `cardano-wallet-read` tests pass
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5205
Summary
Cardano.Wallet.Read.Block.Gen.*modules (Gen, BlockParameters, Shelley, Babbage, Byron) now provided bycardano-ledger-readBuild.hsto importmkBlockEraandBlockParametersfrom the library, definetxsLlocallycardano-ledger-reads-r-p to include Gen modulescardano-wallet-read.cabalNet: -642 lines, 5 modules deleted
Test plan
cabal build lib:cardano-wallet-read -O0— clean, no warningscabal test cardano-wallet-read:test:test— 24 tests passcabal build cardano-wallet-benchmarks:bench:read-blocks— benchmark builds