-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Adding Cosmos Control Visualization Sensor #9122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,024
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Persistent Lines are not getting flushed after the sensor is no longer in use
…ego vehicle, derived LineBatch class
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
Blyron
requested changes
Aug 6, 2025
Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Game/CarlaGameModeBase.cpp
Outdated
Show resolved
Hide resolved
Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Sensor/UE4_Overridden/LineBatchComponent_CARLA.cpp
Outdated
Show resolved
Hide resolved
Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Sensor/UE4_Overridden/LineBatchComponent_CARLA.cpp
Outdated
Show resolved
Hide resolved
Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Sensor/UE4_Overridden/LineBatchComponent_CARLA.cpp
Outdated
Show resolved
Hide resolved
Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Sensor/UE4_Overridden/LineBatchComponent_CARLA.cpp
Outdated
Show resolved
Hide resolved
Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Traffic/RoadSpline.h
Outdated
Show resolved
Hide resolved
Blyron
previously approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm when the CI/CD green passes
Blyron
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new type of CosmosControlSensor, sensor with the requirements for a Control Signal for the Cosmos environment.
The sensor can be spawned with the
cosmos_visualization
definition in python.Added a ULineBatchComponent derived class that renders exclusively on the CosmosControlSensor.
Added a new material for the sensor, which uses an exponential falloff by @Aperiss
@Aperiss Added a new class to extract xodr files road data and make it available in the GameMode.
Fixes #
Where has this been tested?
Possible Drawbacks
This change is