Skip to content

FIX ROS2 transformation calculation #9123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

csonthomisi
Copy link

@csonthomisi csonthomisi commented Aug 6, 2025

Description

I found an error in the calculation of ROS2 transformations from CARLA data and corrected it. I would be happy to help, if you allow me! It would fill me with great pride!

Fixes #

Where has this been tested?

  • Platform(s): Ubuntu
  • Python version(s): 3.10
  • Unreal Engine version(s): 4.26

Possible Drawbacks

No drawbacks, just correct ROS2 transformation frames!


This change is Reviewable

@csonthomisi csonthomisi requested a review from a team as a code owner August 6, 2025 15:58
Copy link

update-docs bot commented Aug 6, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes.

@Blyron
Copy link
Contributor

Blyron commented Aug 6, 2025

How is this suppossed to change? I cannot see changing the flow. Just reordering the operations. Could you explain?

@csonthomisi
Copy link
Author

How is this suppossed to change? I cannot see changing the flow. Just reordering the operations. Could you explain?

Actually the code on ue4-dev branch calculates wrong cause using : float(M_PI_2) / 180.0f
But the correct degree to radians calculation is: float(M_PI) / 180.0f;

So it's a minor typo fixed by me and also i think the reordering was just for myself to be more readable :)

@Blyron
Copy link
Contributor

Blyron commented Aug 6, 2025

Yeah I have seen it. We will try to merge this week
We have some merges on going rn
Good job!

@Blyron Blyron merged commit a46b269 into carla-simulator:ue4-dev Aug 7, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants