Skip to content

Fixed Traffic Signals being spawned in the air #9239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Blyron merged 2 commits into from
Sep 8, 2025
Merged

Fixed Traffic Signals being spawned in the air #9239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
704f197
Add AdjustSignHeightToGround method to ensure traffic signs are place…
LuisPovedaCano Sep 8, 2025
a0d91e2
use variable instead a magic number for the offset, and lowered it to…
LuisPovedaCano Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Traffic/TrafficLightManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,8 @@ void ATrafficLightManager::SpawnTrafficLights()
SpawnRotation.Roll = 0;
SpawnRotation.Pitch = 0;

AdjustSignHeightToGround(SpawnLocation);

FActorSpawnParameters SpawnParams;
SpawnParams.Owner = this;
SpawnParams.SpawnCollisionHandlingOverride =
Expand Down Expand Up @@ -667,6 +669,8 @@ void ATrafficLightManager::SpawnSignals()
SpawnRotation.Roll = 0;
SpawnRotation.Pitch = 0;

AdjustSignHeightToGround(SpawnLocation);

FActorSpawnParameters SpawnParams;
SpawnParams.Owner = this;
SpawnParams.SpawnCollisionHandlingOverride =
Expand Down Expand Up @@ -724,6 +728,8 @@ void ATrafficLightManager::SpawnSignals()
SpawnRotation.Roll = 0;
SpawnRotation.Pitch = 0;

AdjustSignHeightToGround(SpawnLocation);

FActorSpawnParameters SpawnParams;
SpawnParams.Owner = this;
SpawnParams.SpawnCollisionHandlingOverride =
Expand Down Expand Up @@ -863,3 +869,30 @@ void ATrafficLightManager::RemoveAttachedProps(TArray<AActor*> Actors) const
Actor->Destroy();
}
}

void ATrafficLightManager::AdjustSignHeightToGround(FVector& SpawnLocation) const
{
const FVector Start = SpawnLocation + FVector(0, 0, 10000.0f);
const FVector End = SpawnLocation - FVector(0, 0, 10000.0f);

FHitResult HitResult;
FCollisionQueryParams CollisionParams;
CollisionParams.bTraceComplex = true;
CollisionParams.bReturnPhysicalMaterial = false;

constexpr float ZOffsetSignToGround = 0.5f;
if (GetWorld()->LineTraceSingleByChannel(
HitResult,
Start,
End,
ECC_WorldStatic,
CollisionParams))
{
SpawnLocation.Z = HitResult.Location.Z + ZOffsetSignToGround;
}
else
{
carla::log_warning("Could not find ground for traffic sign placement at location",
TCHAR_TO_UTF8(*SpawnLocation.ToString()));
}
}
2 changes: 2 additions & 0 deletions Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Traffic/TrafficLightManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ class CARLA_API ATrafficLightManager : public AActor

void RemoveAttachedProps(TArray<AActor*> Actors) const;

void AdjustSignHeightToGround(FVector& SpawnLocation) const;

// Mapped references to ATrafficLightGroup (junction)
UPROPERTY()
TMap<int, ATrafficLightGroup *> TrafficGroups;
Expand Down
Loading