feat: add no-internal #2
Conversation
|
I'm getting timeouts on the tests for |
Tests for rules that use type information are slow. Really slow. Each test is a full-blown TS compile. Not sure where the timeout setting resides. I assumed that it was my grossly-under-powered, don't-care-if-it-gets-nicked notebook (that I use for talks at meetups, etc.) that was the issue. I don't recall seeing timeouts on my MacBook. |
| { | ||
| code: stripIndent` | ||
| import { concat } from 'rxjs/internal/observable/concat'; | ||
| import { map } from 'rxjs/internal/operators/map';`, |
There was a problem hiding this comment.
Isn't this test identical to the one above? Did you intend to split the the two imports into two tests, so that each test includes only a single import?
There was a problem hiding this comment.
One for single quotes and the other one for double quotes.
In the tslint code the selector checked for quotes because it used the "raw" value of the import. We know check on the value (so without any quotes) so, this can indeed be removed 👍
| }, | ||
| create: context => { | ||
| return { | ||
| ["ImportDeclaration Literal[value=/^rxjs\\u002finternal/]"]: ( |
There was a problem hiding this comment.
Wow. I love this!!! I don't think it needs to be a computed property though. A quoted key should be fine, AFAICT.
cartant
left a comment
cartant
left a comment
There was a problem hiding this comment.
Thanks. This looks great. Just a couple of minor nits. The selector is freaking awesome!!!
I've bumped the timeout - specified in the |
I was on energy save mode, which apparently is a whole lot slower... Now, it runs with the initial timeout time. |
- Fix types in package.json causing package to masquerade as ESM - Change the default export to be a more helpful name to avoid import-x/no-rename-default. - Fix incorrect default export in CJS due to a known issue with unbuild.
2 participants
A part of #1
tslint: