Skip to content

Conversation

@aboyton
Copy link
Contributor

@aboyton aboyton commented Oct 26, 2020

Format the code blocks to make them look more similar so that the differences are more obvious.

This is different compared to how Prettier formats them, but I found it really hard to work out what was different when both the code and the formatting was different.

Format the code blocks to make them look more similar so that the differences are more obvious.

This is different compared to how Prettier formats them, but I found it really hard to work out what was different when both the code and the formatting was different.
Copy link
Owner

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree. Thanks.

@cartant cartant merged commit f211e65 into cartant:main Oct 26, 2020
@aboyton
Copy link
Contributor Author

aboyton commented Oct 26, 2020

Well those are some of the fastest code reviews and merges I've ever seen.

Thanks for making this repo and porting over all the rules, especially the two a former colleague of mine wrote (suffix-subjects and no-exposed-subjects) which you've now migrated for us.

This repo will really help with our migration to ESLint.

@cartant
Copy link
Owner

cartant commented Oct 26, 2020

No worries, I was working in the RxJS repo - on PRs - hence the speedy merges.

@aboyton
Copy link
Contributor Author

aboyton commented Oct 26, 2020

Also helps when you're a fellow Aussie and thus in the same timezone.

Danevandy99 pushed a commit to Danevandy99/eslint-plugin-rxjs that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants