fix(rules): Remove unrestricted_all_ports rule from CIS AWS networking #2336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
The
unrestricted_all_portsrule was incorrectly placed incis_aws_networking.pydespite not being an actual CIS benchmark control:cis:5.X) - only hadcis:aws-5.0(benchmark version)unrestricted_all_portsinstead ofcis_aws_5_X_...naming conventionprotocol=-1cases via theirOR rule.protocol = '-1'clausesThis PR removes the rule to maintain accuracy of CIS benchmark mappings.
Related issues or links
Checklist
General
make lint).Proof of functionality
N/A - This is a removal of a rule that had no tests. Existing tests continue to pass.
Notes for reviewers
The rule being removed checked for security groups with
protocol = '-1'(all traffic) from0.0.0.0/0. While this is a valid security concern, it's not a CIS benchmark control. The existing CIS 5.1 and 5.2 rules already catch this case through theirOR rule.protocol = '-1'conditions.🤖 Generated with Claude Code