chore(deps): Upgrade Neo4j Python driver to 6.0.0

[jychp]

Type of change

• Breaking change (fix or feature that would cause existing functionality to change)

Summary

Upgrade the Neo4j Python driver from 5.x to 6.0.0. The driver 6.0.0 removes legacy transaction methods, requiring migration to the new API:

• read_transaction → execute_read
• write_transaction → execute_write

This change updates all usages across the codebase, including source files, tests, and documentation.

Related issues or links

• Closes chore: update neo4j python driver to 6.0.0 #1979

Breaking changes

Neo4j database compatibility:

• Neo4j 5.x: Fully supported (recommended)
• Neo4j 4.x: Compatible according to Neo4j documentation

How was this tested?

• CI will verify integration tests against both Neo4j 4.x and 5.x database versions

Checklist

General

• I have read the contributing guidelines.
• The linter passes locally (make lint).
• I have added/updated tests that prove my fix is effective or my feature works.

Proof of functionality

• New or updated unit/integration tests.

Notes for reviewers

This is a straightforward API migration. The new methods (execute_read/execute_write) have the same signatures as the old ones, so the changes are purely mechanical replacements.

[cubic-dev-ai]

3 issues found across 19 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="tests/unit/cartography/client/test_core.py">

<violation number="1" location="tests/unit/cartography/client/test_core.py:19">
P1: Rule violated: **Tests and documentation quality**

This test still asserts a mocked session call count (`execute_write.assert_not_called()`), which violates the rule to test outcomes in the graph rather than mock interactions. Refactor the test to validate graph state (e.g., using check_nodes/check_rels) or remove the mock-based assertion per the rule’s 'Test outcomes, not implementation' clause.</violation>
</file>

<file name="tests/unit/driftdetect/test_detector.py">

<violation number="1" location="tests/unit/driftdetect/test_detector.py:41">
P1: Rule violated: **Tests and documentation quality**

Tests should verify outcomes (graph/state data) rather than asserting mock call parameters. The added `execute_read.assert_called_with(...)` lines are mock-parameter assertions, which this rule explicitly forbids. Replace these with assertions on the resulting state/graph data instead.</violation>
</file>

<file name="tests/unit/cartography/intel/aws/test_resourcegroupstaggingapi.py">

<violation number="1" location="tests/unit/cartography/intel/aws/test_resourcegroupstaggingapi.py:93">
P1: Rule violated: **Tests and documentation quality**

Test asserts a mock call count instead of verifying graph outcomes. The rule "Test outcomes, not implementation" requires tests to validate graph data (e.g., via check_nodes/check_rels) rather than mock call counts.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[kunaals]

lgtm