Skip to content

Conversation

@jychp
Copy link
Collaborator

@jychp jychp commented Feb 5, 2026

Type of change

  • New feature (non-breaking change that adds functionality)

Summary

This PR adds missing ontology mappings for user account nodes that have the UserAccount semantic label but were not mapped in useraccounts.py. This enables cross-platform identity resolution and querying for these node types.

Changes:

  • GitLabUser: Added mapping with email, username, fullname, and active (based on state) fields
  • OCIUser: Added mapping with email, fullname, has_mfa, and active (based on lifecycle_state) fields
  • OCIUserSchema: Added UserAccount semantic label to enable ontology integration
  • JamfTenant: Added documentation comment noting minimal properties (no mappable fields)

Related issues or links

  • Improves ontology coverage for identity resolution across platforms

How was this tested?

  • Linter passes (make test_lint)
  • Code follows existing patterns in useraccounts.py (e.g., GitHubUser, OktaUser mappings)

Checklist

General

  • I have read the contributing guidelines.
  • The linter passes locally (make lint).
  • I have added/updated tests that prove my fix is effective or my feature works.

Proof of functionality

  • Screenshot showing the graph before and after changes.
  • New or updated unit/integration tests.

If you are changing a node or relationship

Notes for reviewers

The mappings follow the same patterns used for similar user account nodes (GitHubUser, OktaUser, etc.). The active field uses equal_boolean special handling to convert state values to boolean.

- Add GitLabUser mapping to useraccounts.py (email, username, fullname, active)
- Add OCIUser mapping to useraccounts.py (email, fullname, has_mfa, active)
- Add UserAccount semantic label to OCIUserSchema
- Add JamfTenant comment to tenants.py (minimal properties)
- Update schema docs for GitLabUser and OCIUser with ontology notes

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Jeremy Chapeau <jeremy@subimage.io>
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

@jychp jychp enabled auto-merge (squash) February 5, 2026 17:02
@jychp jychp merged commit e53a9a1 into master Feb 5, 2026
8 checks passed
@jychp jychp deleted the jeremy/ontology-missing-nodes branch February 5, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants