Improve Gutter

[martijn00]

Add optional size and scaleFactor parameters

const Gutter(size: 20, scaleFactor: 3, type: GutterType.large)

Introduce constructors on Gutter for types like small, large, etc

const Gutter.tiny();
const Gutter.small();
const Gutter.medium();
const Gutter.large();
const Gutter.extraLarge();

Add Gutter.expand

const Gutter.expand()

Add extension to add Gutter on Lists

<Widget>[
    const Text('Test1'),
    const Text('Test2'),
    const Text('Test3'),
  ].withGutter() // Optional parameter to set which Gutter size you want to use

Add AdaptiveGutter that switches Gutter size based on the current breakpoint

const AdaptiveGutter(
    small: Gutter.tiny(),
    medium: Gutter.large(),
    large: Gutter.extraLarge(),
  )

Migrate to flutter_adaptive_scaffold to remove deprecated package

flutter_adaptive_scaffold: ^0.1.11+1

[Ladegeraet]

Love this PR! I just visit the repo to fork it and implement this 👍 Thanks :-)

[martijn00]

What do you mean by "visit the repo to fork it and implement this"? Is there any changes needed, or do you want to merge this?

[Ladegeraet]

I meant that I was start to working on implementing similar improvements when I stumbled upon your PR. 😁 u just saved me some time 👍

[caseycrogers]

Looks great! I had a handful of nits and one or two larger questions.

FYI I think I added a ruleset that enables the CI stuff you added, but not totally sure so let me know if that's not working.

[martijn00]

@caseycrogers I'll get back to some more changes tomorrow. The CI still doesn't work so it would be great if you can fix that.

[caseycrogers]

I think your CI/CD won't work until after the PR is merged, no?

If you want you could send me a separate PR with just the CI/CD stuff and I can merge it and see if that fixes it.

[martijn00]

@caseycrogers I've fixed the issues and made a separate PR for CI in case you want to merge that one in first.

Let me know if you have any other feedback.

[martijn00]

@caseycrogers you need to enable CD in pub dev for deployment to work. Go to https://pub.dev/packages/flutter_gutter/admin

Select: Enable publishing from GitHub Actions
Set repo: caseycrogers/flutter_gutter
Tag pattern: v{{version}}
Enable both:
Enable publishing from push events
Enable publishing from workflow_dispatch events

[caseycrogers]

I left one final review comment on AdaptiveGutter, I'm still not totally getting the point (see relevant comment), but otherwise ready to ship.

[martijn00]

Sounds good! We use SlotLayout quite a bit in our apps, especially to scale things on web or windowed screens that can resize on the fly. That's probably why i would like to use it this way, but it is just a small wrapper and could be done in our app code as well. I thought it would be useful to others as well maybe.

[martijn00]

The build works now! After you've fixed the admin access things on pub you can merge this, make a v2.0.0 tag on the repo and it will do the work for you.

[caseycrogers]

LGTM, I'll ship this later today, thanks a lot of the contribution I really appreciate it!!

[caseycrogers]

Why are we adding the floor here? Shouldn't Flutter handle any non-pixel boundaries when it converts to physical pixels?

Also, if we DO want to keep the floor in, shouldn't it apply after multiplying by scale factor?

Either way I'll just merge and ship this now and if we want to pull the floor back out I'll handle that in a patch version because I don't want to leave you stuck in async review h*ll.

[martijn00]

I'm making some more changes right now. Just found some stuff. I'll also add some tests