Add fix for boundsInWindow incorrectly calculating position on screen#1983
Merged
geoff-powell merged 3 commits intomasterfrom Jul 2, 2025
Merged
Add fix for boundsInWindow incorrectly calculating position on screen#1983geoff-powell merged 3 commits intomasterfrom
geoff-powell merged 3 commits intomasterfrom
Conversation
geoff-powell
requested review from
BrianGardnerAtl,
colinmarsch,
gamepro65 and
jrodbx
geoff-powell
force-pushed
the
gpowell/compose-accessibility-fixes
branch
5 times, most recently
from
82464b4 to
81b69fe
Compare
colinmarsch
approved these changes
Jun 5, 2025
Collaborator
colinmarsch
left a comment
colinmarsch
left a comment
There was a problem hiding this comment.
We didn't have any tests in the repo that failed due to this issue?
geoff-powell
force-pushed
the
gpowell/compose-accessibility-fixes
branch
from
81b69fe to
bcafc5d
Compare
geoff-powell
force-pushed
the
gpowell/compose-accessibility-fixes
branch
from
bcafc5d to
918a05e
Compare
geoff-powell
added a commit
that referenced
this pull request
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SemanticsNode.boundsInWindow was incorrectly reporting bounds with compose 1.8.x update.
This uses a combination of boundsInRoot and locationOnScreen to correctly calculate displayBounds.
Example of bug:
