Run builds on Java 24#1989
Merged
geoff-powell merged 1 commit intomasterfrom Jul 21, 2025
Merged
Conversation
geoff-powell
force-pushed
the
gpowell/java24
branch
from
c193607 to
b9683ef
Compare
geoff-powell
requested review from
BrianGardnerAtl,
gamepro65,
jrodbx and
nak5ive
jrodbx
approved these changes
Jul 18, 2025
| ubuntu-latest | ||
| ] | ||
| java-version: [17, 21, 23] | ||
| java-version: [17, 21, 23, 24] |
Collaborator
There was a problem hiding this comment.
nit: replace 23 with 24, instead of appending?
geoff-powell
force-pushed
the
gpowell/java24
branch
4 times, most recently
from
c511005 to
1d2d8fc
Compare
geoff-powell
force-pushed
the
gpowell/java24
branch
from
1d2d8fc to
91a8b05
Compare
jrodbx
reviewed
Jul 21, 2025
|
|
||
| view.doOnAttach { | ||
| val lifecycleOwner = ViewTreeLifecycleOwner.get(view)!! | ||
| val lifecycleOwner = view.findViewTreeSavedStateRegistryOwner()!! |
Collaborator
There was a problem hiding this comment.
should this have been merged in this PR? why was this needed for Java 24?
Closed
geoff-powell
added a commit
that referenced
this pull request
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.