A11y renderer: handle nodes with alpha=0f or HideFromAccessibility #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancoisBlavoet
changed the title
FrancoisBlavoet
commented
Sep 8, 2025
| private fun SemanticsNode.hasZeroAlpha(): Boolean { | ||
| // try to reflectively query internal SemanticsNode.isTransparent() by iterating on kotlin field mangled names: | ||
| val candidateGetterNames = arrayOf( | ||
| "isTransparent", |
Author
There was a problem hiding this comment.
This is very ugly, unless there is an alternative way to get this info, we should get Compose to expose this property
FrancoisBlavoet
changed the title
TWiStErRob
reviewed
Sep 10, 2025
paparazzi/src/main/java/app/cash/paparazzi/accessibility/AccessibilityRenderExtension.kt
Outdated
Show resolved
Hide resolved
FrancoisBlavoet
changed the title
FrancoisBlavoet
force-pushed
the
a11y-alpha-hidden
branch
from
f88856d to
2618567
Compare
FrancoisBlavoet
commented
Jan 12, 2026
Author
There was a problem hiding this comment.
this dropdown is detected as transparent. That's not ideal, but the "before" screenshot is also incorrect and does not display the dropdown content, so the after is technically correct.
This happens because DropdownMenu is a Popup and AFAIK paparazzi can only render content in the main window
The ideal state would be to display both windows, but that's out of the scope of this PR.
Author
|
@TWiStErRob no hurry, but could I get another review on this? Ideally, if that PR looks good, then it would be nice to get it included in alpha3 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugly fix for #2093
The current approach to check for
modifier == Modifier.alpha(0f)only works if you use this exact modifier.In particular,
Modifier.graphicsLayer { alpha = 0f }won't match this check.Unfortunately, Compose does not really expose anything that we could use to identify a transparent node.
There is however an internal function allowing us to detect this.
Ideally we would get the compose team to make it public (or otherwise expose this information another way), but in the mean time I have written this ugly reflective way to access this information
This also adds a check for
HideFromAccessibilitysince this is a new replacement forInvisibleToUser, we need to check for that one too.