Introduce defaultLocale system property#2203
Merged
jrodbx merged 7 commits intocashapp:masterfrom Jan 15, 2026
Merged
Conversation
...s/locale-qualifier/src/test/java/app/cash/paparazzi/plugin/test/DefaultLocaleSnapshotTest.kt
Outdated
Show resolved
Hide resolved
jrodbx
requested changes
Dec 29, 2025
...s/locale-qualifier/src/test/java/app/cash/paparazzi/plugin/test/DefaultLocaleSnapshotTest.kt
Outdated
Show resolved
Hide resolved
...s/locale-qualifier/src/test/java/app/cash/paparazzi/plugin/test/DefaultLocaleSnapshotTest.kt
Outdated
Show resolved
Hide resolved
...s/locale-qualifier/src/test/java/app/cash/paparazzi/plugin/test/DefaultLocaleSnapshotTest.kt
Outdated
Show resolved
Hide resolved
.../src/test/snapshots/images/app.cash.paparazzi.plugin.test_LocaleQualifierTest_locale[GB].png
Show resolved
Hide resolved
...s/locale-qualifier/src/test/java/app/cash/paparazzi/plugin/test/DefaultLocaleSnapshotTest.kt
Outdated
Show resolved
Hide resolved
nishatoma
changed the title
jrodbx
approved these changes
Jan 14, 2026
Collaborator
jrodbx
left a comment
jrodbx
left a comment
There was a problem hiding this comment.
Left some follow-up comments. Thanks for the contribution!
paparazzi-gradle-plugin/src/test/projects/locale-qualifier/src/gradle.properties
Outdated
Show resolved
Hide resolved
jrodbx
reviewed
Jan 15, 2026
paparazzi-gradle-plugin/src/test/projects/locale-qualifier/src/gradle.properties
Outdated
Show resolved
Hide resolved
.../projects/locale-qualifier/src/test/java/app/cash/paparazzi/plugin/test/DefaultLocaleTest.kt
Outdated
Show resolved
Hide resolved
.../projects/locale-qualifier/src/test/java/app/cash/paparazzi/plugin/test/DefaultLocaleTest.kt
Outdated
Show resolved
Hide resolved
jrodbx
reviewed
Jan 15, 2026
.../projects/locale-qualifier/src/test/java/app/cash/paparazzi/plugin/test/DefaultLocaleTest.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1982 by adding a
app.cash.paparazzi.defaultLocalesystem property.If this is a concept the team wants to go ahead with, I'm also open to suggestions on whether this default value should be left empty (and up to the consumer) or whether to actually set it to something like
en-rUSas per @yogurtearl's suggestion!Thank you in advance for any feedback.
Closes #1982