Skip to content
This repository was archived by the owner on Apr 30, 2024. It is now read-only.

Replace ORG_GITHUB_TOKEN with ADMIN_GITHUB_TOKEN#658

Merged
zackkrida merged 1 commit intomasterfrom
remove_org_token
Sep 13, 2020
Merged

Replace ORG_GITHUB_TOKEN with ADMIN_GITHUB_TOKEN#658
zackkrida merged 1 commit intomasterfrom
remove_org_token

Conversation

@dhruvkb
Copy link
Copy Markdown
Contributor

@dhruvkb dhruvkb commented Sep 12, 2020

Description

For consistency, all code must use ADMIN_GITHUB_TOKEN instead of ORG_GITHUB_TOKEN.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested review from a team as code owners September 12, 2020 08:02
@dhruvkb dhruvkb requested review from hugosolar, kgodey and nimishbongale and removed request for a team, hugosolar and nimishbongale September 12, 2020 08:02
@zackkrida zackkrida merged commit 38b939f into master Sep 13, 2020
@zackkrida zackkrida deleted the remove_org_token branch September 13, 2020 02:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants