Skip to content
This repository was archived by the owner on Apr 30, 2024. It is now read-only.

Switch to a11y Colors#685

Merged
zackkrida merged 1 commit intomasterfrom
a11y-colors
Sep 23, 2020
Merged

Switch to a11y Colors#685
zackkrida merged 1 commit intomasterfrom
a11y-colors

Conversation

@zackkrida
Copy link
Copy Markdown
Contributor

@zackkrida zackkrida commented Sep 23, 2020

Fixes

Fixes #455 by @ayanchoudhary
Fixes #454 by @ayanchoudhary
Fixes #476 by @ayanchoudhary
Fixes #519 by @zackkrida

Description

Switches our colors over to their accessible replacements, and updates vocabulary stories to match. Adds a new color brighter-dark-slate-blue, all other colors are replacements of existing colors.

Technical details

Tests

Screenshots

before

before

after

after

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested review from a team as code owners September 23, 2020 03:04
@zackkrida zackkrida requested review from a team, Dhruvi16, dhruvkb, fcoveram and hugosolar and removed request for a team September 23, 2020 03:04
@zackkrida zackkrida self-assigned this Sep 23, 2020
@zackkrida zackkrida added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 📄 aspect: text Concerns the textual material in the repository 🟧 priority: high Stalls work on the project or its dependents labels Sep 23, 2020
@zackkrida zackkrida merged commit acf5346 into master Sep 23, 2020
@zackkrida zackkrida deleted the a11y-colors branch September 23, 2020 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

💻 aspect: code Concerns the software code in the repository 📄 aspect: text Concerns the textual material in the repository ✨ goal: improvement Improvement to an existing feature 🟧 priority: high Stalls work on the project or its dependents

Development

Successfully merging this pull request may close these issues.

[META] Contrast Issues Contrast Issue of search button Contrast Issues in caption, search placeholder and tags Contrast Issues in links

6 participants