Skip to content

Ci/ubuntu 18 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Ci/ubuntu 18 #79

wants to merge 6 commits into from

Conversation

ixzzd
Copy link
Contributor

@ixzzd ixzzd commented May 27, 2021

I faced the GLIBC mismatch issue on Debian stable

/lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by ./rescript-react-intl-extractor)

Here is exactly the same issue that I had with rescript-vscode plugin:
rescript-lang/rescript-vscode#216

GH actions linux-latest version was updated recently, Let's lock it on ubuntu 18.04 for now?

@cknitt
Copy link
Member

cknitt commented May 27, 2021

Github is showing me again the changes that I merged already, strange.

What is the reason for ubuntu-18.04?

Also, because of the problems I had with esy on Windows, I am currently revamping build/CI/test to migrate away from esy and use opam directly, see #78.

@ixzzd
Copy link
Contributor Author

ixzzd commented May 27, 2021

Github is showing me again the changes that I merged already, strange.

For me as well 😬 Not sure what's wrong, but I will try to fix it.

What is the reason for ubuntu-18.04?

I propose to use ubuntu-18.04 to get rid of Glibc mismatch issue (Debian 10, current stable, has Glibc 2.28). I updated the PR description

@cknitt
Copy link
Member

cknitt commented May 27, 2021

Ah, ok, I'll include the ubuntu-18.04 in my PR then.
I am planning to publish a release over the weekend BTW.

@ixzzd
Copy link
Contributor Author

ixzzd commented May 27, 2021

I am planning to publish a release over the weekend BTW.

This is great, thank you 🙏

Github is showing me again the changes that I merged already, strange.

I rebased my branch, fixed now

@cknitt
Copy link
Member

cknitt commented May 27, 2021

ubuntu-18.04 is merged with #78 already.

@cknitt cknitt closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants