fixed layer norm quantization annotation #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, should we file a PR on the main branch? |
I created the PR to fix it. |
cccclai
pushed a commit
that referenced
this pull request
Feb 25, 2025
) In preparation for replacing the checked-in files in shim/ with https://github.com/facebook/buck2-shims-meta as a submodule. The portions of this diff that are not a pure move are: creation of shim_et/BUCK symlink shim/tools to shim_et/tools so that fbsource//tools movement of Android toolchains from shim/BUCK to shim_et/BUCK because they are not present in buck2-shims-meta edits to .buckconfig edit to Utils.cmake to point at shim_et// instead of shim// edit to shim_et/README.md (note that shim/README.md will come back when shim/ is a submodule pointing to buck2-shims-meta)
cccclai
pushed a commit
that referenced
this pull request
May 29, 2025
Differential Revision: D75104487 Pull Request resolved: pytorch#11021
cccclai
pushed a commit
that referenced
this pull request
Jun 10, 2025
Differential Revision: D75718888 Pull Request resolved: pytorch#11444
cccclai
pushed a commit
that referenced
this pull request
Jun 13, 2025
Differential Revision: D76157744 Pull Request resolved: pytorch#11501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.