-
-
Notifications
You must be signed in to change notification settings - Fork 134
feat: intlConfig support all NumberFormatOptions #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: intlConfig support all NumberFormatOptions #386
Conversation
Mentioning @cchanxzy to trigger CI |
Hey @cchanxzy & maintainers! When you're available please consider reviewing and merging this PR. CI checks have failed but it seems to be an issue with the CI itself as local builds and tests pass normally. Thank you for maintaining this package 🙏 |
829f478
to
94977d2
Compare
94977d2
to
9d80cb4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 414 415 +1
Branches 156 162 +6
=========================================
+ Hits 414 415 +1 ☔ View full report in Codecov by Sentry. |
@agunghapsah Thank you for this contribution! If you're interested in adding more new features, feel free to check out v4.0.0-alpha |
# [3.10.0](v3.9.2...v3.10.0) (2025-02-22) ### Features * intlConfig support all NumberFormatOptions ([#386](#386)) ([0b84349](0b84349))
🎉 This PR is included in version 3.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [4.0.0-alpha.3](v4.0.0-alpha.2...v4.0.0-alpha.3) (2025-02-22) ### Bug Fixes * add react 19 as peer dependency ([396d57b](396d57b)), closes [#380](#380) * handle cases where decimalSeparator is empty ([#385](#385)) ([656e5c2](656e5c2)) ### Features * intlConfig support all NumberFormatOptions ([#386](#386)) ([0b84349](0b84349)) * merge changes in main into alpha branch ([6985156](6985156))
🎉 This PR is included in version 4.0.0-alpha.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
intlConfig
currently only exposeslocale
andcurrency
.This PR adds full support for
Intl.NumberFormatOptions
.Fixes #253
Passing
{ useGrouping: true }
fixes #356