Skip to content

feat: intlConfig support all NumberFormatOptions #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

agunghapsah
Copy link
Contributor

intlConfig currently only exposes locale and currency.

This PR adds full support for Intl.NumberFormatOptions.

Fixes #253
Passing { useGrouping: true } fixes #356

@agunghapsah
Copy link
Contributor Author

Mentioning @cchanxzy to trigger CI

@agunghapsah
Copy link
Contributor Author

Hey @cchanxzy & maintainers!

When you're available please consider reviewing and merging this PR.
Would love to be able to customize the underlying Intl formatting and not have to deal with prefixes myself.

CI checks have failed but it seems to be an issue with the CI itself as local builds and tests pass normally.

Thank you for maintaining this package 🙏

@cchanxzy cchanxzy force-pushed the pr/intl-number-format-options; branch from 829f478 to 94977d2 Compare February 22, 2025 09:12
@cchanxzy cchanxzy force-pushed the pr/intl-number-format-options; branch from 94977d2 to 9d80cb4 Compare February 22, 2025 09:39
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (396d57b) to head (9d80cb4).
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #386   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          414       415    +1     
  Branches       156       162    +6     
=========================================
+ Hits           414       415    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cchanxzy cchanxzy merged commit 0b84349 into cchanxzy:main Feb 22, 2025
2 checks passed
@cchanxzy
Copy link
Owner

@agunghapsah Thank you for this contribution!

If you're interested in adding more new features, feel free to check out v4.0.0-alpha

github-actions bot pushed a commit that referenced this pull request Feb 22, 2025
# [3.10.0](v3.9.2...v3.10.0) (2025-02-22)

### Features

* intlConfig support all NumberFormatOptions ([#386](#386)) ([0b84349](0b84349))
Copy link

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 22, 2025
# [4.0.0-alpha.3](v4.0.0-alpha.2...v4.0.0-alpha.3) (2025-02-22)

### Bug Fixes

* add react 19 as peer dependency ([396d57b](396d57b)), closes [#380](#380)
* handle cases where decimalSeparator is empty ([#385](#385)) ([656e5c2](656e5c2))

### Features

* intlConfig support all NumberFormatOptions ([#386](#386)) ([0b84349](0b84349))
* merge changes in main into alpha branch ([6985156](6985156))
Copy link

🎉 This PR is included in version 4.0.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currency Input Component Displays Incorrect Format Add support for currencyDisplay attribute in IntlConfig
3 participants