fix: handle cases where decimalSeparator is empty #385
Conversation
|
Hi @cchanxzy and maintainers! 👋 I'm currently encountering this exact issue with JPY in my production application. When entering values in a JPY input (e.g., "700"), after blur the value gets converted incorrectly to "7". This is causing significant problems for our Japanese users. Would it be possible to get a review of this PR? Let me know if there's anything I can do to help move this forward, such as providing additional test cases or helping with review. Thank you for maintaining this useful package! |
There was a problem hiding this comment.
Tested locally, everything works fine. The test coverage also seems quite complete.
We want to adopt this library for https://opencollective.com, and this is the last bit blocking adoption. Happy to help with whatever's needed to bring this PR to main!
Previously, for zero-decimal currencies (such as JPY), input will be lost on blur if `decimalScale` is used (no matter what value was passed in). This was down to the fact that `decimalSeparator` from `getLocaleConfig` will be `undefined` (since it doesn't exist in the output of `formatToParts`), and the fallback value of `''` was used. This PR adds handling in the pad/trim logic to skip all processing when we see `''` as the separator.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 414 427 +13
Branches 156 168 +12
=========================================
+ Hits 414 427 +13 ☔ View full report in Codecov by Sentry. |
## [3.9.2](v3.9.1...v3.9.2) (2025-02-22) ### Bug Fixes * handle cases where decimalSeparator is empty ([#385](#385)) ([656e5c2](656e5c2))
|
🎉 This PR is included in version 3.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@pmmmwh looks good, thank you for the contribution! If you're interested in adding more new features, feel free to check out v4.0.0-alpha |
# [4.0.0-alpha.3](v4.0.0-alpha.2...v4.0.0-alpha.3) (2025-02-22) ### Bug Fixes * add react 19 as peer dependency ([396d57b](396d57b)), closes [#380](#380) * handle cases where decimalSeparator is empty ([#385](#385)) ([656e5c2](656e5c2)) ### Features * intlConfig support all NumberFormatOptions ([#386](#386)) ([0b84349](0b84349)) * merge changes in main into alpha branch ([6985156](6985156))
|
🎉 This PR is included in version 4.0.0-alpha.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Previously, for zero-decimal currencies (such as JPY), input will be lost on blur if
decimalScaleis used (no matter what value was passed in). This was down to the fact thatdecimalSeparatorfromgetLocaleConfigwill beundefined(since it doesn't exist in the output offormatToParts), and the fallback value of''was used.This PR adds handling in the pad/trim logic to skip all processing when we see
''as the separator.Re-opened since #379 was closed due to staleness.
Fixes #310