Date is not validated correctly as type: string, format: date-time

[severinwullschleger]

Hi

I want to return the created and lastModified timestamp from the database which I define in my ORM with type Date.

If I print the response object in my express router before returning it, it looks like this:

User {
   id: '1fe87c1d-5d31-4426-8757-aa5e62d2344e',
   lastModified: 2020-02-21T09:26:43.603Z,
   created: 2020-02-21T09:25:48.151Z,

If I call the endpoint I get the following reponse object:

{
  "data": [
    {
      "id": "1fe87c1d-5d31-4426-8757-aa5e62d2344e",
      "lastModified": "2020-02-21T09:26:43.603Z",
      "created": "2020-02-21T09:25:48.151Z"
    },
...

-> correctly stringified

As soon as I set the validateResponses option in the OpenApiValidator on true, I get the following error message:

{
  "error": ".response.data[0].lastModified should be string, .response.data[0].created should be string,

... although it is a string in the upper example

[martinbark]

I just hit this same issue today. It's because the date is an object not a string. At the point the response it validated it's still a Date object. When you print it date.toJSON() is called to convert it to a string. It's not specific to Date, you would see this issue on any object that has a toJSON() function

The only reliable way i found to work around this is to JSON.stringify() then JSON.parse() the response body before it's validated. This means the response body is now formatted as the destination will see the message before it's validated.

I added this code after OpenApiValidator was been installed as a workaround

app.use((req, res, next) => {
  const original = res.json;
  res.json = function jsonp(json) {
    return original.call(this, JSON.parse(JSON.stringify(json)));
  };
  next();
});

[severinwullschleger]

Thanks a lot. The workaround worked for me too.

[electrotype]

Using send seems to be required for me instead:

  app.use((req, res, next) => {
    const original = res.send;
    res.send = function jsonp(json) {
      return original.call(this, JSON.parse(JSON.stringify(json)));
    };
    next();
  });

[Dakuan]

horrible

[Dakuan]

Using send seems to be required for me instead:

  app.use((req, res, next) => {
    const original = res.send;
    res.send = function jsonp(json) {
      return original.call(this, JSON.parse(JSON.stringify(json)));
    };
    next();
  });

unfortunately this will change your content type though...

[cdimascio]

Thanks @Dakuan, this being worked on. You can follow along here. #493

[cdimascio]

This is resolved in v4.10.0. please give it a try!