Skip to content

Breaking change in signature for resolver function #952

Closed
@csuermann

Description

@csuermann

Describe the bug
#921 changed the signature of the resolver function from

resolver: Function;

to

resolver: (
    handlersPath: string,
    route: RouteMetadata,
    apiDoc: OpenAPIV3.Document,
  ) => RequestHandler | Promise<RequestHandler>;

This breaks backwards-compatibility as Express request handlers can also be arrays of request handlers.

I believe the signature should instead be

resolver: (
    handlersPath: string,
    route: RouteMetadata,
    apiDoc: OpenAPIV3.Document,
  ) => RequestHandler | Promise<RequestHandler> | Array<RequestHandler> | Promise<Array<RequestHandler>>;

Unfortunately more tweaks seem to be required which I haven't found the time to investigate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions