Skip to content

Bugfix: config.Etcd.Mandatory must not be nil #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Conversation

cyrilst
Copy link
Contributor

@cyrilst cyrilst commented Jun 2, 2025

No description provided.

@cyrilst cyrilst self-assigned this Jun 2, 2025
Copy link

github-actions bot commented Jun 2, 2025

File Coverage
All files 19%
cmd/sshproxy-dumpd/sshproxy-dumpd.go 0%
cmd/sshproxy-replay/sshproxy-replay.go 0%
cmd/sshproxy/commands.go 0%
cmd/sshproxy/recorder.go 0%
cmd/sshproxy/sshproxy.go 26%
cmd/sshproxyctl/sshproxyctl.go 0%
pkg/nodesets/nodesets.go 35%
pkg/record/record.go 0%
pkg/utils/config.go 100%
pkg/utils/configv1.go 100%
pkg/utils/etcd.go 0%
pkg/utils/logging.go 58%
pkg/utils/route.go 10%
pkg/utils/utils.go 92%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against d377073

@cyrilst cyrilst requested review from t-valette, fdiakh and od-cea June 2, 2025 09:53
@cyrilst cyrilst marked this pull request as ready for review June 2, 2025 09:53
Copy link
Member

@od-cea od-cea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
This is also clearer that etcd is not mandatory by default.
Thanks!

@cyrilst cyrilst merged commit e69258d into master Jun 2, 2025
7 checks passed
@cyrilst cyrilst deleted the etcdMandatory branch June 2, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants