Skip to content

Path reference fix #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Path reference fix #102

wants to merge 3 commits into from

Conversation

izucken
Copy link
Contributor

@izucken izucken commented Mar 1, 2021

If referenced path object contained a common referenced parameters, reference resolution for path object would produce an E_NOTICE due to indirect dynamic property modification attempt. If silenced or ignored, the resulting object would still be able to return expected results, but references would not be actually resolved.

Path object in v3 has only one array property which can contain references (common parameters).

Updates to test vendor references had to be done to pass all green.

The same problem was already addressed recently #87.
Would be great to have a patch release if this get to be merged!

@cebe cebe added this to the 1.5.2 milestone Apr 20, 2021
@cebe cebe closed this in 54d9d01 May 24, 2021
@cebe
Copy link
Owner

cebe commented May 24, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants