Adjust default value for Schema:: when no type is specified #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaytrase
reviewed
Nov 2, 2021
| // nullable is only relevant, when a type is specified | ||
| // return null as default when there is no type | ||
| // return false as default when there is a type | ||
| 'nullable' => $this->hasProperty('type') ? false : null, |
There was a problem hiding this comment.
At what point this is calculated? Is schema->type mutable? Is this possible?
// nullable is undefined if no type is given
$schema = Reader::readFromJson('{"oneOf": [{"type": "string"}, {"type": "integer"}]}', Schema::class);
$this->assertNull($schema->type);
$this->assertNull($schema->nullable);
$schema->type = Type::STRING;
$this->assertFalse($schema->nullable);If it's not mutable - looks good
There was a problem hiding this comment.
this is executed on demand, e.g. in case the property is accessed.
There was a problem hiding this comment.
ok, then I think we need to fix this as a testcase
scaytrase
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #131