Static analysis with PHPStan #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebe
requested changes
Dec 5, 2019
| @@ -31,7 +31,7 @@ | |||
| class Paths implements SpecObjectInterface, DocumentContextInterface, ArrayAccess, Countable, IteratorAggregate | |||
| { | |||
| /** | |||
| * @var PathItem[] | |||
| * @var (PathItem|null)[] | |||
There was a problem hiding this comment.
not sure if I understand this correctly. But this looks like it could be an array of nulls? does not make much sense to me.
There was a problem hiding this comment.
Look at line 53. The $_paths array can contain nulls as it's items.
| @@ -43,7 +43,7 @@ class Paths implements SpecObjectInterface, DocumentContextInterface, ArrayAcces | |||
|
|
|||
| /** | |||
| * Create an object from spec data. | |||
| * @param PathItem[]|array[] $data spec data read from YAML or JSON | |||
| * @param (PathItem|array|null)[] $data spec data read from YAML or JSON | |||
There was a problem hiding this comment.
same here, could you explain this change please?
There was a problem hiding this comment.
Same reason as above..
Co-Authored-By: Carsten Brandt <[email protected]>
cebe
approved these changes
Dec 13, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got it up to level 5 with just a few simple changes, but level 6 starts to reqire typehints and suddenly we have 150+ errors, so level 5 it is for now..