Add support for Symfony/YAML 4.4 #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @cebe Could you please tell me when this pull request is going to be merged? We want to use cebe/php-openapi in our project, but lack of symfony/Yaml 4.4 support blocks us. I would be appreciate to merge it as quick as it possible :) |
|
I was explicitly excluding this version because of bugs in the yaml implementation, see #60 If it does not break my tests I can add it back, need to check it. |
cebe
reviewed
May 27, 2020
|
updated composer.json, lets see if tests are green. Tests are running on 4.3 anyway so that should work. |
|
https://travis-ci.org/github/cebe/php-openapi/builds/691798677 tests are fine, seems phpstan is broken... |
|
Merged, Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Symfony/YAML 4.4, this is a transition version to 5. In 4.4 you can fix/remove deprecated code before migrate to version 5