Skip to content

Nuget - Error if using platform other than x86 or x64 #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2014

Conversation

amaitland
Copy link
Member

Add platform check to give error if using platform other than x86 or x64

@amaitland
Copy link
Member Author

@jornh Hopefully this will help eliminate some of the AnyCPU related queries.

@jornh
Copy link
Contributor

jornh commented Oct 22, 2014

Excellent idea! 👍 ... I'll take it for a spin some time tonight ...

I think I heard someone mention the other day that if you code handle something programatically you probably should. 😄 Much better than the panic-noisy thing I added to the README on the NuGet site. + We can turn down the sad messages in the FAQ etc. one notch too.

@jornh
Copy link
Contributor

jornh commented Oct 22, 2014

Oh boy, completely worn down battery - on me, not my PC. so won't be tonight with this one!

@amaitland
Copy link
Member Author

No problem 😄

@jornh
Copy link
Contributor

jornh commented Oct 24, 2014

almost merged due to green AppVeyor. Then realized it doesn't touch this .targets ... Duuh! merging anyway. Then if you can build and push staging VS2012 NuGet 33.0.2 packages I can test it with "MinEx"

Or you got a better plan?

jornh added a commit that referenced this pull request Oct 24, 2014
Nuget - Error if using platform other than x86 or x64
@jornh jornh merged commit 3cfeaef into cefsharp:master Oct 24, 2014
@amaitland
Copy link
Member Author

Or you got a better plan?

Works for me!

@amaitland amaitland deleted the feature/nuget-platform-check branch October 24, 2014 05:02
@jornh jornh added this to the 33.0.2 milestone Oct 24, 2014
@jornh
Copy link
Contributor

jornh commented Oct 24, 2014

Ok 👍 , I updated milestones a bit ... Dates are of course best optimistic guesses 😜

@amaitland
Copy link
Member Author

👍

@amaitland
Copy link
Member Author

33.0.2 packages are up on staging.

@jornh
Copy link
Contributor

jornh commented Oct 24, 2014

Minimal Example OK with 33.0.2 👍 ... works as usual.

Surprisingly enough when I add an AnyCPU platform if says:
Error 1 CefSharp.Common does not work correctly on 'AnyCPU' platform. You need to specify platform (x86 / x64). CefSharp.MinimalExample.Wpf

I guess next step is simply to nuget push, GH tag and pop a bottle of milk?

@amaitland
Copy link
Member Author

I guess next step is simply to nuget push, GH tag and pop a bottle of milk?

I'll upload to nuget proper sometime today (most likely tonight my time) 😄

@jornh
Copy link
Contributor

jornh commented Oct 27, 2014

👍

@amaitland
Copy link
Member Author

After a false start with 33.0.1, we now have 33.0.2 on nuget 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants