Fix string reverse member overload name#1045
Merged
TristonianJones merged 1 commit intoOct 21, 2024
Merged
Conversation
jcking
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the string
reverse()overload id to be unique to the type.In the future overload IDs for a given function should not be equal to
the function name as this can interfere with dynamic dispatch for a
parsed-only expression.
This change should be a no-op for anyone using
reversetoday asthe behavior will effectively cause existing expressions to use the
dynamic dispatch rather than the specific overload once more overloads
are introduced under the
reversefunction.