Canonical environment description and stdlib subsetting#1125
Merged
Conversation
l46kok
previously approved these changes
Feb 10, 2025
l46kok
approved these changes
Feb 11, 2025
|
This resolved #1050 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for subsetting the CEL standard environment via a canonical environment
description which is YAML-serializable.
This change also removes a behavior which would potentially break forward compatible
changes, as now type declarations are not included into the variable declaration set.
In the past a duplicate declaration for
intwould accept the precedence of the variablewith the same name (erroring if there were type differences) rather than permitting
the user-provided variable to mask the type identifier.
Closes #1078
Closes #899
Closes #844
Closes #290