add support for handling unknown expression ids in test result#1183
Merged
Conversation
jnthntatum
requested changes
Jun 2, 2025
jnthntatum
left a comment
jnthntatum
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, some minor suggestions
use cmp package for calculating expected and actual unkown diff corrected error message for unknown result matcher diff
aakash070
force-pushed
the
unknown_set_result_matcher
branch
from
7b5f95c to
4e59ff4
Compare
jnthntatum
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for Unknown Set test result. A new test runner option has been added which enables the
OptPartialEvaleval option.Note: This change adds partial evaluation support for cases where top level variables are missing in the input activations.