ext/lists: add max size check to genRange() to prevent OOM#1310
Merged
Conversation
lists.range(N) allocates N elements with no upper bound. A large value like 2147483647 allocates ~16 GB and crashes the process. This is dangerous in Kubernetes ValidatingAdmissionPolicy where user-controlled input feeds into CEL expressions. Add maxRangeSize (10M) check and reject negative values.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
CLA signed. Please re-check. |
Collaborator
|
/gcbrun |
Move the hardcoded maxRangeSize constant into a ListsMaxRangeSize functional option on the Lists library, following the same pattern as ListsVersion. Default remains 10,000,000. Setting to zero disables the limit.
Contributor
Author
|
Done — moved it to a |
Collaborator
|
/gcbrun |
Adjust the default limit for range down to 1M
Collaborator
|
/gcbrun |
TristonianJones
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lists.range(N) allocates N elements with no upper bound. A large
value like 2147483647 allocates ~16 GB and crashes the process.
This is dangerous in Kubernetes ValidatingAdmissionPolicy where
user-controlled input feeds into CEL expressions.
Add maxRangeSize (10M) check and reject negative values.
Fixes #1309