feat: integrate popsigner#65
Merged
Merged
Conversation
Introduces a new signer package that provides a unified interface for creating Celestia keyrings. Supports two backends: - Local: filesystem-based keyring using cosmos-sdk keyring - POPSigner: remote signing service via POPSigner SDK The package directly returns keyring.Keyring instances, keeping the implementation simple and leveraging existing cosmos-sdk abstractions. Configuration is done via nested TOML structure: [celestia.signer] mode = "local" or "popsigner" [celestia.signer.local] keyring_path = "..." key_name = "..." [celestia.signer.popsigner] api_key = "..." key_id = "..."
- Update TxClientConfig to use signer.Config - Modify initTxClient to use signer.NewKeyring factory - Add CLI flags for nested signer configuration - Maintain backwards compatibility with legacy flat config - Support both TOML config and CLI flag configuration
Add !/signer to Dockerfile.dockerignore to ensure the signer package is included when building the Docker image.
- Add signer architecture diagram to README - Document both local and POPSigner options - Update CLI flags and environment variables section - Add detailed TOML configuration examples - Update config.toml.example with nested signer structure
tuxcanfly
requested changes
Feb 24, 2026
tuxcanfly
requested changes
Mar 6, 2026
Member
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new signer package to unify Celestia transaction signing across multiple backends, and integrates POPSigner as a remote-signing option while updating configuration and documentation to match the new model.
Changes:
- Add
signerpackage with factory/config and implementations for local keyring, POPSigner, and AWS KMS. - Update Celestia tx client initialization to use
signer.NewKeyring(signer.Config)instead of inline keyring init logic. - Update CLI/TOML example configuration and README to document signer modes and new config structure.
Reviewed changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
signer/signer.go |
Package documentation for the new signer factory module. |
signer/factory.go |
Keyring factory selecting backend by mode. |
signer/config.go |
Signer config schema + validation + env var resolution helpers. |
signer/local.go |
Local filesystem keyring creation via celestia-node helper. |
signer/popsigner.go |
POPSigner-backed keyring creation and validation. |
signer/aws_kms.go |
AWS KMS-backed keyring creation. |
celestia_storage.go |
Switch tx-client init to use the new signer-based keyring creation and return key name. |
cmd/daserver/config.go |
Introduce nested celestia.signer config and legacy migration logic into signer.Config. |
cmd/daserver/config_builder.go |
Wire new remote-signer CLI flags into config building. |
cmd/daserver/flags.go |
Add CLI flags for signer mode + POPSigner parameters. |
cmd/daserver/config_legacy_test.go |
Add tests covering some legacy AWS KMS mapping/validation. |
config.toml.example |
Add signer configuration section and POPSigner docs to the sample config. |
README.md |
Document signer options and update examples/flag tables. |
go.mod / go.sum |
Add POPSigner SDK dependency. |
Dockerfile.dockerignore |
Ensure the new signer/ directory is included in Docker builds. |
.gitignore |
Adjust daserver ignore rule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
thank you for 806b58a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Tested on Mocha: https://mocha.celenium.io/address/celestia1su2l6v5a0cj6yg05gp9cuvfen74t8u8rvck836?tab=transactions in this namespace (https://mocha.celenium.io/tx/3eb4c273b9adb1286096b7938de5696c370b518f093eb52b2f8e562d619af2a5?tab=messages)
Built on this PR using
docker buildthen substituted the image locally in the docker-compose.yaml when setting up based on this guide: https://celestiaorg.github.io/docs-preview/pr-2395/build/stacks/optimism/popkins-popsigner/