nsyshid: Play Emulated Portal Audio via Mono Audio #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deReeperJosh
force-pushed
the
portalaudio
branch
from
6035a68 to
c9c7afa
Compare
Exzap
reviewed
Jan 30, 2025
goeiecool9999
requested changes
Jan 30, 2025
deReeperJosh
force-pushed
the
portalaudio
branch
from
cd19f60 to
eb1945e
Compare
|
Discovered a strange bug where every re-launch of Cemu would require the settings window to be opened at least once to play audio, will re-publish when I have found a fix |
deReeperJosh
force-pushed
the
portalaudio
branch
from
eb1945e to
2b23c6b
Compare
|
Found the issue with Audio at startup, there was still a reference to a ternery operator, and the AudioType wasn't being passed through correctly in IAudioAPI |
deReeperJosh
force-pushed
the
portalaudio
branch
from
aeb4fd8 to
1349146
Compare
|
Looks good. Thanks! |
|
I know this is CEMU, but is there a chance this would be implemented in RPCS3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Skylanders games, the portal that is currently emulated is the Trap Team portal. Normally it writes requests via the SetReport method, but the trap team portal also accepts audio requests via the Write method. The portal attached to the Trap Team portal is a Mono audio, 8000hz speaker, and audio requests are 64 bytes, which is 32 16 bit PCM audio samples.
I have also made the portal audio a setting similar to gamepad/tv audio, as well as changing some methods to allow for more than a binary choice when playing audio output.