Skip to content

Update year bounds to address API changes #124 #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Update year bounds to address API changes #124 #125

merged 3 commits into from
Apr 20, 2021

Conversation

ronnie-llamado
Copy link
Member

Update years bounds from [2013,2017] to [2017,2019] to reflect the API changes (Issue #124)

Year changes in ACS.products.ACS.__init__() and test_functional_products.py.

@ronnie-llamado
Copy link
Member Author

I had the same failure on my machine, but was hoping it was just a local issue. Darn.

I think this due to another API change on TIGER map service limiting the size of requests to 32MB. I've gotten around this by choosing a much smaller metropolitan statistical area than Austin, TX. This gets around the testing for this, but has larger implications. I'll add a separate issue.

@ronnie-llamado
Copy link
Member Author

I've added #126 to point out the failure in test_functional_products.py, seen in build Build #1464.

@ljwolf
Copy link
Member

ljwolf commented Apr 12, 2021

Wow, great, thanks! I'll try to get this reviewed & merged this week.

@ronnie-llamado ronnie-llamado mentioned this pull request Apr 20, 2021
@ljwolf ljwolf merged commit 8e353d6 into cenpy-devs:master Apr 20, 2021
@ronnie-llamado ronnie-llamado deleted the issue-124 branch April 20, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants