fix tracing enabled when log level is LogLevelNone #115
+54
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a significant CPU time spent in
traceInPusheven though my log level isLogLevelNone.The core issue is that log level constants are not ordered in a consistent way (neither high to low, nor low to high):
Because of this, check
level >= c.config.LogLeveldoes not work as expected inlogLevelEnabledand for clients with LogLevel not specified (zero value is LogLevelNone)logLevelEnabledalways returns true.Fixing the order of constants would be a proper fix, but can possibly break some users code depending on numerical values.
Instead I add explicit check for
LogLevelNoneinlogLevelEnabled. This should be backwards compatible, unless users actually expectLogLevelNoneto be equal toLogLevelTrace.