Skip to content

Conversation

@seidju
Copy link
Contributor

@seidju seidju commented Apr 22, 2022

  • handle access to serversSubs dict only from syncQueue
  • minor code-style refactoring

@FZambia
Copy link
Member

FZambia commented Apr 25, 2022

Thanks for a fix!

Looking at formatting changes - how those were generated? When I am trying to re-format the code using ctrl + i in XCode I get the different format style. Not sure I really want all these changes to be merged at this point since there is an ongoing work on next SDK iteration in https://github.com/centrifugal/centrifuge-swift/tree/new_protocol branch

@seidju
Copy link
Contributor Author

seidju commented Apr 25, 2022

@FZambia It was made by AppCode, I can re-submit PR without changes of code-style, I guess it would be better

@FZambia
Copy link
Member

FZambia commented Apr 25, 2022

I can re-submit PR without changes of code-style, I guess it would be better

Yep, thanks, will definitely simplify the workflow at this point

handle access to serversSubs dict only from syncQueue
@seidju seidju force-pushed the bugfix/sync-access-to-serverSubs branch from b182ff0 to 40b5a0e Compare April 25, 2022 11:41
@FZambia FZambia merged commit 1894690 into centrifugal:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants