Skip to content

Conversation

@FZambia
Copy link
Member

@FZambia FZambia commented Nov 28, 2024

This PR makes it possible to use RedisShardConfig.Address to configure Sentinel or Cluster based setups by including more addresses and extends Redis URL parsing.

@codecov
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 78.67647% with 29 lines in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (ab848d1) to head (5162858).
Report is 1 commits behind head on v0.34.0_dev.

Files with missing lines Patch % Lines
broker_redis.go 60.46% 12 Missing and 5 partials ⚠️
redis_shard.go 86.51% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           v0.34.0_dev     #427      +/-   ##
===============================================
+ Coverage        82.97%   83.11%   +0.13%     
===============================================
  Files               39       39              
  Lines             8721     8781      +60     
===============================================
+ Hits              7236     7298      +62     
+ Misses            1124     1122       -2     
  Partials           361      361              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FZambia FZambia changed the base branch from master to v0.34.0_dev December 13, 2024 18:10
@FZambia FZambia merged commit 756ee3d into v0.34.0_dev Dec 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants