Add history TTL configuration validation during message publishing #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent runtime errors caused by incorrect TTL configurations
yinheli
force-pushed
the
feature/history-ttl-validation
branch
from
7caef5e to
fe1d4a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements history TTL configuration validation during message publishing to prevent runtime errors caused by incorrect TTL configurations.
Background
This addresses #367, which was created in response to the Redis XADD errors reported in centrifugal/centrifugo#768
Users encountered the following error when
history_ttlwas configured to be greater thanhistory_meta_ttl: